Hi everyone, I am looking to contribute to OpenELIS Global and recently raised a PR #2889 to restrict patient image upload. The PR adds a configuration property that allows admins to fully disable patient image uploads, with updates to both the frontend and backend to respect this setting. I have also attached screenshots showing the changes. It has been a couple of days but I haven’t heard back on a review yet. Could someone from the team please take a look when they get a chance? If there is anything that needs to be changed or improved, please let me know and I will get it fixed as soon as possible. Thank you!
1 Like
Thanks @Taniya .
can you add a screen recording of your new changes ??
2 Likes
I have attached a screen recording. Please check it here Feat(2889) - Add configuration to disable patient image file upload by taniy8 · Pull Request #2968 · DIGI-UW/OpenELIS-Global-2 · GitHub
I noticed that this PR includes a very large number of changes across multiple files. It seems that along with the feature implementation, many formatting updates were also introduced.
Because of this, it becomes difficult to clearly review the actual changes related to the solution for this issue.
It might be helpful to separate formatting changes from the feature implementation so reviewers can focus on the functional updates more easily. @Taniya
sir I review this pr it have formetting changes and some import updation This makes the diff quite large and harder to review. @Moses_Mutesasira
Thanks for the feedback. I’ve addressed this. The PR has been cleaned up and now only shows the 8 files directly related to the feature implementation. The formatting noise has been removed and the diff is much easier to review now. Please take another look at PR #2968! @priyanshu56
I reviewed this. it looks good
1 Like